Skip checksum when download file failed. #3079
Conversation
This comment was marked as spam.
This comment was marked as spam.
|
@Buguin are you still interested in completing this PR? |
Sorry，I'm too busy working this time. Recently, I will make a push to solve the problem of not being able to return when an error is reported in the following code. |
I have transformed nvm_download_artifact function, which allows you to determine the download status based on the execution results. |
nvm.sh
Outdated
| nvm_err "Downloading ${TARBALL_URL}..." | ||
| nvm_download -L -C - "${PROGRESS_BAR}" "${TARBALL_URL}" -o "${TARBALL}" || ( | ||
| download_result=$(nvm_download_v2 -L -C - "${PROGRESS_BAR}" "${TARBALL_URL}" -o "${TARBALL}") | ||
| nvm_err "Download Http Status ${download_result}" |
There was a problem hiding this comment.
i think we don't want to print this in the common success case, and probably not even in the error case. You can, however, wrap it in a NVM_DEBUG check for debugging:
| nvm_err "Download Http Status ${download_result}" | |
| if [ "${NVM_DEBUG-}" = 1 ]; then | |
| nvm_err "Download Http Status ${download_result}" | |
| fi |
ljharb
force-pushed
the
master
branch
2 times, most recently
from
c6cfc3a
to
c20db2a
Compare
|
I've rebased this, but it still needs tests. @Buguin any chance you're still interesting in completing this PR? |
Fixes #3075
Check if the file is successfully downloaded